Commit 3f388f28 authored by Alexey Kardashevskiy's avatar Alexey Kardashevskiy Committed by Linus Torvalds
Browse files

panic: dump registers on panic_on_warn 



Currently we print stack and registers for ordinary warnings but we do not
for panic_on_warn which looks as oversight - panic() will reboot the
machine but won't print registers.

This moves printing of registers and modules earlier.

This does not move the stack dumping as panic() dumps it.

Signed-off-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: Rafael Aquini <aquini@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Deacon <will@kernel.org>
Cc: Nicholas Piggin <npiggin@gmail.com>
Link: https://lkml.kernel.org/r/20200804095054.68724-1-aik@ozlabs.ru


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 85094c05

kernel/panic.c

+6 −6
Original line number Diff line number Diff line
@@ -589,6 +589,11 @@ void __warn(const char *file, int line, void *caller, unsigned taint, 
	if (args)

		vprintk(args->fmt, args->args);



	print_modules();



	if (regs)

		show_regs(regs);



	if (panic_on_warn) {

		/*

		 * This thread may hit another WARN() in the panic path.
@@ -600,11 +605,6 @@ void __warn(const char *file, int line, void *caller, unsigned taint, 
		panic("panic_on_warn set ...\n");

	}



	print_modules();



	if (regs)

		show_regs(regs);

	else

	dump_stack();



	print_irqtrace_events(current);