Commit 3f2d3018 authored by Xiaofei Tan's avatar Xiaofei Tan Committed by Alexandre Belloni
Browse files

rtc: mxc: Replace spin_lock_irqsave with spin_lock in hard IRQ 



It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: default avatarXiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1612355981-6764-6-git-send-email-tanxiaofei@huawei.com
parent 669022c2

drivers/rtc/rtc-mxc.c

+2 −3
Original line number Diff line number Diff line
@@ -189,11 +189,10 @@ static irqreturn_t mxc_rtc_interrupt(int irq, void *dev_id) 
	struct platform_device *pdev = dev_id;

	struct rtc_plat_data *pdata = platform_get_drvdata(pdev);

	void __iomem *ioaddr = pdata->ioaddr;

	unsigned long flags;

	u32 status;

	u32 events = 0;



	spin_lock_irqsave(&pdata->rtc->irq_lock, flags);

	spin_lock(&pdata->rtc->irq_lock);

	status = readw(ioaddr + RTC_RTCISR) & readw(ioaddr + RTC_RTCIENR);

	/* clear interrupt sources */

	writew(status, ioaddr + RTC_RTCISR);
@@ -209,7 +208,7 @@ static irqreturn_t mxc_rtc_interrupt(int irq, void *dev_id) 
		events |= (RTC_PF | RTC_IRQF);



	rtc_update_irq(pdata->rtc, 1, events);

	spin_unlock_irqrestore(&pdata->rtc->irq_lock, flags);

	spin_unlock(&pdata->rtc->irq_lock);



	return IRQ_HANDLED;

}