Commit 3f07ce8e authored by Zou Wei's avatar Zou Wei Committed by David S. Miller
Browse files

net: dsa: hellcreek: Use is_zero_ether_addr() instead of memcmp() 



Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZou Wei <zou_wei@huawei.com>
Reviewed-by: default avatarKurt Kanzenbach <kurt@linutronix.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cda9de0b

drivers/net/dsa/hirschmann/hellcreek.c

+1 −2
Original line number Diff line number Diff line
@@ -927,7 +927,6 @@ static int hellcreek_fdb_dump(struct dsa_switch *ds, int port, 


	/* Read table */

	for (i = 0; i < hellcreek->fdb_entries; ++i) {

		unsigned char null_addr[ETH_ALEN] = { 0 };

		struct hellcreek_fdb_entry entry = { 0 };



		/* Read entry */
@@ -937,7 +936,7 @@ static int hellcreek_fdb_dump(struct dsa_switch *ds, int port, 
		hellcreek_write(hellcreek, 0x00, HR_FDBRDH);



		/* Check valid */

		if (!memcmp(entry.mac, null_addr, ETH_ALEN))

		if (is_zero_ether_addr(entry.mac))

			continue;



		/* Check port mask */