Commit 3eddaa60 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

drbd: use bvec_kmap_local in recv_dless_read 



Using local kmaps slightly reduces the chances to stray writes, and
the bvec interface cleans up the code a little bit.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Link: https://lore.kernel.org/r/20220303111905.321089-10-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 47227850

drivers/block/drbd/drbd_receiver.c

+2 −2
Original line number Diff line number Diff line
@@ -2017,10 +2017,10 @@ static int recv_dless_read(struct drbd_peer_device *peer_device, struct drbd_req 
	D_ASSERT(peer_device->device, sector == bio->bi_iter.bi_sector);



	bio_for_each_segment(bvec, bio, iter) {

		void *mapped = kmap(bvec.bv_page) + bvec.bv_offset;

		void *mapped = bvec_kmap_local(&bvec);

		expect = min_t(int, data_size, bvec.bv_len);

		err = drbd_recv_all_warn(peer_device->connection, mapped, expect);

		kunmap(bvec.bv_page);

		kunmap_local(mapped);

		if (err)

			return err;

		data_size -= expect;