Commit 3eb9dcc0 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: Remove the 'update_scaling' local variable 

This patch does not change any functionality but makes the next patch in
this series easier to read.

Link: https://lore.kernel.org/r/20211203231950.193369-12-bvanassche@acm.org


Tested-by: default avatarBean Huo <beanhuo@micron.com>
Reviewed-by: default avatarBean Huo <beanhuo@micron.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 511a083b

drivers/scsi/ufs/ufshcd.c

+2 −5
Original line number Diff line number Diff line
@@ -5225,7 +5225,6 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba, 
	struct scsi_cmnd *cmd;

	int result;

	int index;

	bool update_scaling = false;



	for_each_set_bit(index, &completed_reqs, hba->nutrs) {

		lrbp = &hba->lrb[index];
@@ -5243,18 +5242,16 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba, 
			/* Do not touch lrbp after scsi done */

			scsi_done(cmd);

			ufshcd_release(hba);

			update_scaling = true;

			ufshcd_clk_scaling_update_busy(hba);

		} else if (lrbp->command_type == UTP_CMD_TYPE_DEV_MANAGE ||

			lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {

			if (hba->dev_cmd.complete) {

				ufshcd_add_command_trace(hba, index,

							 UFS_DEV_COMP);

				complete(hba->dev_cmd.complete);

				update_scaling = true;

				ufshcd_clk_scaling_update_busy(hba);

			}

		}

		if (update_scaling)

			ufshcd_clk_scaling_update_busy(hba);

	}

}