Unverified Commit 3e943697 authored by Ranjani Sridharan's avatar Ranjani Sridharan Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda: Do not stop/start DMA during pause/release 



The FW does not pause/stop the host DMA during pause and stopping the
host DMA from the driver could result in an unknown behaviour. So, skip
triggering the HD-Audio host DMA during pause/release.

Signed-off-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230420114137.27613-2-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 09cda705

sound/soc/sof/intel/hda-stream.c

+10 −1
Original line number Diff line number Diff line
@@ -337,7 +337,13 @@ int hda_dsp_stream_trigger(struct snd_sof_dev *sdev, 
	/* cmd must be for audio stream */

	switch (cmd) {

	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:

		if (!sdev->dspless_mode_selected)

			break;

		fallthrough;

	case SNDRV_PCM_TRIGGER_START:

		if (hstream->running)

			break;



		snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTCTL,

					1 << hstream->index,

					1 << hstream->index);
@@ -360,8 +366,11 @@ int hda_dsp_stream_trigger(struct snd_sof_dev *sdev, 
			hstream->running = true;



		break;

	case SNDRV_PCM_TRIGGER_SUSPEND:

	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:

		if (!sdev->dspless_mode_selected)

			break;

		fallthrough;

	case SNDRV_PCM_TRIGGER_SUSPEND:

	case SNDRV_PCM_TRIGGER_STOP:

		snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR,

					sd_offset,