Commit 3e899fec authored by Armin Wolf's avatar Armin Wolf Committed by Hans de Goede
Browse files

platform/x86: dell-ddv: Add support for interface version 3 



While trying to solve a bugreport on bugzilla, i learned that
some devices (for example the Dell XPS 17 9710) provide a more
recent DDV WMI interface (version 3).
Since the new interface version just adds an additional method,
no code changes are necessary apart from whitelisting the version.

Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20230126194021.381092-2-W_Armin@gmx.de


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent d1fcb749

drivers/platform/x86/dell/dell-wmi-ddv.c

+4 −2
Original line number Diff line number Diff line
@@ -26,7 +26,8 @@ 


#define DRIVER_NAME	"dell-wmi-ddv"



#define DELL_DDV_SUPPORTED_INTERFACE 2

#define DELL_DDV_SUPPORTED_VERSION_MIN	2

#define DELL_DDV_SUPPORTED_VERSION_MAX	3

#define DELL_DDV_GUID	"8A42EA14-4F2A-FD45-6422-0087F7A7E608"



#define DELL_EPPID_LENGTH	20
@@ -49,6 +50,7 @@ enum dell_ddv_method { 
	DELL_DDV_BATTERY_RAW_ANALYTICS_START	= 0x0E,

	DELL_DDV_BATTERY_RAW_ANALYTICS		= 0x0F,

	DELL_DDV_BATTERY_DESIGN_VOLTAGE		= 0x10,

	DELL_DDV_BATTERY_RAW_ANALYTICS_A_BLOCK	= 0x11, /* version 3 */



	DELL_DDV_INTERFACE_VERSION		= 0x12,
@@ -340,7 +342,7 @@ static int dell_wmi_ddv_probe(struct wmi_device *wdev, const void *context) 
		return ret;



	dev_dbg(&wdev->dev, "WMI interface version: %d\n", version);

	if (version != DELL_DDV_SUPPORTED_INTERFACE)

	if (version < DELL_DDV_SUPPORTED_VERSION_MIN || version > DELL_DDV_SUPPORTED_VERSION_MAX)

		return -ENODEV;



	data = devm_kzalloc(&wdev->dev, sizeof(*data), GFP_KERNEL);