Commit 3e86a3a3 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq/msi: Check for invalid MSI parent domain usage 



In the upcoming per device MSI domain concept the MSI parent domains are
not allowed to be used as regular MSI domains where the MSI allocation/free
operations are applicable.

Add appropriate checks.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Acked-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221124230313.806128070@linutronix.de
parent e71c5d0b

kernel/irq/msi.c

+14 −3
Original line number Diff line number Diff line
@@ -937,12 +937,20 @@ int msi_domain_alloc_irqs_descs_locked(struct irq_domain *domain, struct device 


	lockdep_assert_held(&dev->msi.data->mutex);



	if (WARN_ON_ONCE(irq_domain_is_msi_parent(domain))) {

		ret = -EINVAL;

		goto free;

	}



	/* Frees allocated descriptors in case of failure. */

	ret = msi_domain_add_simple_msi_descs(info, dev, nvec);

	if (ret)

		return ret;

		goto free;



	ret = ops->domain_alloc_irqs(domain, dev, nvec);

	if (ret)

	if (!ret)

		return 0;

free:

	msi_domain_free_irqs_descs_locked(domain, dev);

	return ret;

}
@@ -1013,6 +1021,9 @@ void msi_domain_free_irqs_descs_locked(struct irq_domain *domain, struct device 


	lockdep_assert_held(&dev->msi.data->mutex);



	if (WARN_ON_ONCE(irq_domain_is_msi_parent(domain)))

		return;



	ops->domain_free_irqs(domain, dev);

	if (ops->msi_post_free)

		ops->msi_post_free(domain, dev);