Commit 3e7f2b8d authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

net: use WARN_ON_ONCE() in inet_sock_destruct() 



inet_sock_destruct() has four warnings which have been
useful to point to kernel bugs in the past.

However they are potentially a problem because they
could flood the syslog.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 76458fae

net/ipv4/af_inet.c

+4 −4
Original line number Diff line number Diff line
@@ -148,10 +148,10 @@ void inet_sock_destruct(struct sock *sk) 
		return;

	}



	WARN_ON(atomic_read(&sk->sk_rmem_alloc));

	WARN_ON(refcount_read(&sk->sk_wmem_alloc));

	WARN_ON(sk->sk_wmem_queued);

	WARN_ON(sk_forward_alloc_get(sk));

	WARN_ON_ONCE(atomic_read(&sk->sk_rmem_alloc));

	WARN_ON_ONCE(refcount_read(&sk->sk_wmem_alloc));

	WARN_ON_ONCE(sk->sk_wmem_queued);

	WARN_ON_ONCE(sk_forward_alloc_get(sk));



	kfree(rcu_dereference_protected(inet->inet_opt, 1));

	dst_release(rcu_dereference_protected(sk->sk_dst_cache, 1));