Commit 3e704897 authored Jun 26, 2023 by Pablo Neira Ayuso

netfilter: nf_tables: unbind non-anonymous set if rule construction fails

Otherwise a dangling reference to a rule object that is gone remains
in the set binding list.

Fixes: 26b5a571 ("netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent f188d300

net/netfilter/nf_tables_api.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -5343,6 +5343,8 @@ void nf_tables_deactivate_set(const struct nft_ctx ctx, struct nft_set set,
		nft_set_trans_unbind(ctx, set);
		if (nft_set_is_anonymous(set))
		nft_deactivate_next(ctx->net, set);
		else
		list_del_rcu(&binding->list);

		set->use--;
		break;