Commit 3e6ac852 authored by Biju Das's avatar Biju Das Committed by Greg Kroah-Hartman
Browse files

usb: gadget: udc: renesas_usb3: Fix RZ/V2M {modprobe,bind} error 



Currently {modprobe, bind} after {rmmod, unbind} results in probe failure.

genirq: Flags mismatch irq 22. 00000004 (85070400.usb3drd) vs. 00000004 (85070400.usb3drd)
renesas_usb3: probe of 85070000.usb3peri failed with error -16

The reason is, it is trying to register an interrupt handler for the same
IRQ twice. The devm_request_irq() was called with the parent device.
So the interrupt handler won't be unregistered when the usb3-peri device
is unbound.

Fix this issue by replacing "parent dev"->"dev" as the irq resource
is managed by this driver.

Fixes: 9cad72df ("usb: gadget: Add support for RZ/V2M USB3DRD driver")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Message-ID: <20230530161720.179927-1-biju.das.jz@bp.renesas.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7b672f28

drivers/usb/gadget/udc/renesas_usb3.c

+2 −2
Original line number Diff line number Diff line
@@ -2877,9 +2877,9 @@ static int renesas_usb3_probe(struct platform_device *pdev) 
		struct rzv2m_usb3drd *ddata = dev_get_drvdata(pdev->dev.parent);



		usb3->drd_reg = ddata->reg;

		ret = devm_request_irq(ddata->dev, ddata->drd_irq,

		ret = devm_request_irq(&pdev->dev, ddata->drd_irq,

				       renesas_usb3_otg_irq, 0,

				       dev_name(ddata->dev), usb3);

				       dev_name(&pdev->dev), usb3);

		if (ret < 0)

			return ret;

	}