Commit 3e68f331 authored by 蒋家盛's avatar 蒋家盛 Committed by Miquel Raynal
Browse files

mtd: onenand: Check for error irq 



For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq() effectively
convert that into -EINVAL, even at probe time rather than later on.
So it might be better to check just now.

Fixes: 2c22120f ("MTD: OneNAND: interrupt based wait support")
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220104162658.1988142-1-jiasheng@iscas.ac.cn
parent 109cf81f

drivers/mtd/nand/onenand/generic.c

+6 −1
Original line number Diff line number Diff line
@@ -53,7 +53,12 @@ static int generic_onenand_probe(struct platform_device *pdev) 
	}



	info->onenand.mmcontrol = pdata ? pdata->mmcontrol : NULL;

	info->onenand.irq = platform_get_irq(pdev, 0);



	err = platform_get_irq(pdev, 0);

	if (err < 0)

		goto out_iounmap;



	info->onenand.irq = err;



	info->mtd.dev.parent = &pdev->dev;

	info->mtd.priv = &info->onenand;