Commit 3e5f1ff7 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Bjorn Andersson
Browse files

hwspinlock: stm32: Use struct_size() helper in devm_kzalloc() 

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.

Also, address the following sparse warnings:
drivers/hwspinlock/stm32_hwspinlock.c:84:32: warning: using sizeof on a flexible structure

Link: https://github.com/KSPP/linux/issues/174


Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: default avatarBaolin Wang <baolin.wang7@gmail.com>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220125021353.GA29777@embeddedor
parent 571c3496

drivers/hwspinlock/stm32_hwspinlock.c

+1 −3
Original line number Diff line number Diff line
@@ -73,15 +73,13 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev) 
	struct device *dev = &pdev->dev;

	struct stm32_hwspinlock *hw;

	void __iomem *io_base;

	size_t array_size;

	int i, ret;



	io_base = devm_platform_ioremap_resource(pdev, 0);

	if (IS_ERR(io_base))

		return PTR_ERR(io_base);



	array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock);

	hw = devm_kzalloc(dev, sizeof(*hw) + array_size, GFP_KERNEL);

	hw = devm_kzalloc(dev, struct_size(hw, bank.lock, STM32_MUTEX_NUM_LOCKS), GFP_KERNEL);

	if (!hw)

		return -ENOMEM;