Commit 3e43d79d authored by Wei Li's avatar Wei Li Committed by Arnaldo Carvalho de Melo
Browse files

perf tools: No need to cache the PMUs in ARM SPE auxtrace init routine 



- auxtrace_record__init() is called only once, so there is no point in
  using a static variable to cache the results of
  find_all_arm_spe_pmus(), make it local and free the results after use.

- Another reason is, even though SPE is micro-architecture dependent,
  but so far it only supports "statistical-profiling-extension-v1" and
  we have no chance to use multiple SPE's PMU events in Perf command.

So remove the useless check code to make it clear.

Signed-off-by: default avatarWei Li <liwei391@huawei.com>
Reviewed-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Hanjun Guo <guohanjun@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kim Phillips <kim.phillips@arm.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lore.kernel.org/lkml/20200724071111.35593-3-liwei391@huawei.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 31e81e0b

tools/perf/arch/arm/util/auxtrace.c

+4 −5
Original line number Diff line number Diff line
@@ -57,16 +57,14 @@ struct auxtrace_record 
	struct evsel *evsel;

	bool found_etm = false;

	struct perf_pmu *found_spe = NULL;

	static struct perf_pmu **arm_spe_pmus = NULL;

	static int nr_spes = 0;

	struct perf_pmu **arm_spe_pmus = NULL;

	int nr_spes = 0;

	int i = 0;



	if (!evlist)

		return NULL;



	cs_etm_pmu = perf_pmu__find(CORESIGHT_ETM_PMU_NAME);



	if (!arm_spe_pmus)

	arm_spe_pmus = find_all_arm_spe_pmus(&nr_spes, err);



	evlist__for_each_entry(evlist, evsel) {
@@ -84,6 +82,7 @@ struct auxtrace_record 
			}

		}

	}

	free(arm_spe_pmus);



	if (found_etm && found_spe) {

		pr_err("Concurrent ARM Coresight ETM and SPE operation not currently supported\n");