Commit 3e253b21 authored by Stephen Boyd's avatar Stephen Boyd
Browse files

ASoC: tlv320aic32x4: pll: Remove impossible condition in clk_aic32x4_pll_determine_rate() 



Smatch warns:

sound/soc/codecs/tlv320aic32x4-clk.c:219 clk_aic32x4_pll_determine_rate() warn: unsigned 'rate' is never less than zero.

Cc: Maxime Ripard <maxime@cerno.tech>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306101217.08CRVGcK-lkp@intel.com/


Fixes: 25d43ec3 ("ASoC: tlv320aic32x4: pll: Switch to determine_rate")
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20230613011201.1166753-1-sboyd@kernel.org


Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
parent be8fa5fd

sound/soc/codecs/tlv320aic32x4-clk.c

+1 −5
Original line number Diff line number Diff line
@@ -208,18 +208,14 @@ static int clk_aic32x4_pll_determine_rate(struct clk_hw *hw, 
					  struct clk_rate_request *req)

{

	struct clk_aic32x4_pll_muldiv settings;

	unsigned long rate;

	int ret;



	ret = clk_aic32x4_pll_calc_muldiv(&settings, req->rate, req->best_parent_rate);

	if (ret < 0)

		return -EINVAL;



	rate = clk_aic32x4_pll_calc_rate(&settings, req->best_parent_rate);

	if (rate < 0)

		return rate;

	req->rate = clk_aic32x4_pll_calc_rate(&settings, req->best_parent_rate);



	req->rate = rate;

	return 0;

}