Commit 3e1f4a2e authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

USB: gadget: legacy: fix an error code in eth_bind() 



This code should return -ENOMEM if the allocation fails but it currently
returns success.

Fixes: 9b95236e ("usb: gadget: ether: allocate and init otg descriptor by otg capabilities")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YBKE9rqVuJEOUWpW@mwanda


Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 045aef3a

drivers/usb/gadget/legacy/ether.c

+3 −1
Original line number Diff line number Diff line
@@ -403,8 +403,10 @@ static int eth_bind(struct usb_composite_dev *cdev) 
		struct usb_descriptor_header *usb_desc;



		usb_desc = usb_otg_descriptor_alloc(gadget);

		if (!usb_desc)

		if (!usb_desc) {

			status = -ENOMEM;

			goto fail1;

		}

		usb_otg_descriptor_init(gadget, usb_desc);

		otg_desc[0] = usb_desc;

		otg_desc[1] = NULL;