Commit 3e0e0988 authored by Navid Emamdoost's avatar Navid Emamdoost Committed by Yuan Can
Browse files

nbd_genl_status: null check for nla_nest_start 

maillist inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I8NC0E
CVE: CVE-2019-16089

Reference: https://lore.kernel.org/lkml/20190911164013.27364-1-navid.emamdoost@gmail.com/



---------------------------

nla_nest_start may fail and return NULL. The check is inserted, and
errno is selected based on other call sites within the same source code.
Update: removed extra new line.
v3 Update: added release reply, thanks to Michal Kubecek for pointing
out.

Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: default avatarMichal Kubecek <mkubecek@suse.cz>
parent 7f55dbd9

drivers/block/nbd.c

+6 −0
Original line number Diff line number Diff line
@@ -2408,6 +2408,12 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info) 
	}



	dev_list = nla_nest_start_noflag(reply, NBD_ATTR_DEVICE_LIST);

	if (!dev_list) {

		nlmsg_free(reply);

		ret = -EMSGSIZE;

		goto out;

	}



	if (index == -1) {

		ret = idr_for_each(&nbd_index_idr, &status_cb, reply);

		if (ret) {