Commit 3ddb4ce1 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

serial: tegra: Fix a mask operation that is always true 



Currently the expression lsr | UART_LSR_TEMT is always true and
this seems suspect. I believe the intent was to mask lsr with UART_LSR_TEMT
to check that bit, so the expression should be using the & operator
instead. Fix this.

Fixes: b9c2470f ("serial: tegra: flush the RX fifo on frame error")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210426105514.23268-1-colin.king@canonical.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6efb943b

drivers/tty/serial/serial-tegra.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -338,7 +338,7 @@ static void tegra_uart_fifo_reset(struct tegra_uart_port *tup, u8 fcr_bits) 




	do {

	do {

		lsr = tegra_uart_read(tup, UART_LSR);

		lsr = tegra_uart_read(tup, UART_LSR);

		if ((lsr | UART_LSR_TEMT) && !(lsr & UART_LSR_DR))

		if ((lsr & UART_LSR_TEMT) && !(lsr & UART_LSR_DR))

			break;

			break;

		udelay(1);

		udelay(1);

	} while (--tmout);

	} while (--tmout);