Commit 3db7285e authored by Bosi Zhang's avatar Bosi Zhang Committed by Stephen Boyd
Browse files

clk: mediatek: fix of_iomap memory leak 



Smatch reports:
drivers/clk/mediatek/clk-mtk.c:583 mtk_clk_simple_probe() warn:
    'base' from of_iomap() not released on lines: 496.

This problem was also found in linux-next. In mtk_clk_simple_probe(),
base is not released when handling errors
if clk_data is not existed, which may cause a leak.
So free_base should be added here to release base.

Fixes: c58cd0e4 ("clk: mediatek: Add mtk_clk_simple_probe() to simplify clock providers")
Signed-off-by: default avatarBosi Zhang <u201911157@hust.edu.cn>
Reviewed-by: default avatarDongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230422084331.47198-1-u201911157@hust.edu.cn


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 18eb864f

drivers/clk/mediatek/clk-mtk.c

+5 −2
Original line number Diff line number Diff line
@@ -500,8 +500,10 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, 
	num_clks += mcd->num_mux_clks + mcd->num_divider_clks;



	clk_data = mtk_alloc_clk_data(num_clks);

	if (!clk_data)

		return -ENOMEM;

	if (!clk_data) {

		r = -ENOMEM;

		goto free_base;

	}



	if (mcd->fixed_clks) {

		r = mtk_clk_register_fixed_clks(mcd->fixed_clks,
@@ -599,6 +601,7 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, 
					      mcd->num_fixed_clks, clk_data);

free_data:

	mtk_free_clk_data(clk_data);

free_base:

	if (mcd->shared_io && base)

		iounmap(base);

	return r;