Commit 3dad011b authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Shuah Khan
Browse files

selftests/resctrl: Pass the real number of tests to show_cache_info() 



Results include warm-up test which is discarded before passing the sum
to show_cache_info(). show_cache_info() handles this by subtracting one
from the number of tests in divisor. It is a trappy construct to have
sum and number of tests parameters to disagree like this.

A more logical place for subtracting the skipped tests is where the sum
is calculated so move it there. Pass the correct number of tests to
show_cache_info() so it can be used directly as the divisor for
calculating the average.

Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Tested-by: default avatarBabu Moger <babu.moger@amd.com>
Tested-by: default avatarShaopeng Tan (Fujitsu) <tan.shaopeng@fujitsu.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 85b73447

tools/testing/selftests/resctrl/cache.c

+1 −1
Original line number Diff line number Diff line
@@ -294,7 +294,7 @@ int show_cache_info(unsigned long sum_llc_val, int no_of_bits, 
	long avg_diff = 0;

	int ret;



	avg_llc_val = sum_llc_val / (num_of_runs - 1);

	avg_llc_val = sum_llc_val / num_of_runs;

	avg_diff = (long)abs(cache_span - avg_llc_val);

	diff_percent = ((float)cache_span - avg_llc_val) / cache_span * 100;

tools/testing/selftests/resctrl/cat_test.c

+1 −1
Original line number Diff line number Diff line
@@ -77,7 +77,7 @@ static int check_results(struct resctrl_val_param *param) 
	no_of_bits = count_bits(param->mask);



	return show_cache_info(sum_llc_perf_miss, no_of_bits, param->span / 64,

			       MAX_DIFF, MAX_DIFF_PERCENT, NUM_OF_RUNS,

			       MAX_DIFF, MAX_DIFF_PERCENT, runs - 1,

			       get_vendor() == ARCH_INTEL, false);

}

tools/testing/selftests/resctrl/cmt_test.c

+1 −1
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ static int check_results(struct resctrl_val_param *param, int no_of_bits) 
	fclose(fp);



	return show_cache_info(sum_llc_occu_resc, no_of_bits, param->span,

			       MAX_DIFF, MAX_DIFF_PERCENT, NUM_OF_RUNS,

			       MAX_DIFF, MAX_DIFF_PERCENT, runs - 1,

			       true, true);

}