Commit 3da73f10 authored Dec 05, 2022 by Miaoqian Lin Committed by Ingo Molnar Jan 07, 2023

objtool: Fix memory leak in create_static_call_sections()



strdup() allocates memory for key_name. We need to release the memory in
the following error paths. Add free() to avoid memory leak.

Fixes: 1e7e4788 ("x86/static_call: Add inline static call implementation for x86-64")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20221205080642.558583-1-linmq006@gmail.com
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>

parent 88603b6d

tools/objtool/check.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -679,6 +679,7 @@ static int create_static_call_sections(struct objtool_file *file)
		if (strncmp(key_name, STATIC_CALL_TRAMP_PREFIX_STR,
		STATIC_CALL_TRAMP_PREFIX_LEN)) {
		WARN("static_call: trampoline name malformed: %s", key_name);
		free(key_name);
		return -1;
		}
		tmp = key_name + STATIC_CALL_TRAMP_PREFIX_LEN - STATIC_CALL_KEY_PREFIX_LEN;
		@@ -688,6 +689,7 @@ static int create_static_call_sections(struct objtool_file *file)
		if (!key_sym) {
		if (!opts.module) {
		WARN("static_call: can't find static_call_key symbol: %s", tmp);
		free(key_name);
		return -1;
		}