Commit 3da72e18 authored by Pierre Gondois's avatar Pierre Gondois Committed by Greg Kroah-Hartman
Browse files

cacheinfo: Decrement refcount in cache_setup_of_node() 



Refcounts to DT nodes are only incremented in the function
and never decremented. Decrease the refcounts when necessary.

Signed-off-by: default avatarPierre Gondois <pierre.gondois@arm.com>
Reviewed-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20221026185954.991547-1-pierre.gondois@arm.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 189a87f8

drivers/base/cacheinfo.c

+11 −6
Original line number Diff line number Diff line
@@ -196,7 +196,7 @@ static void cache_of_set_props(struct cacheinfo *this_leaf, 


static int cache_setup_of_node(unsigned int cpu)

{

	struct device_node *np;

	struct device_node *np, *prev;

	struct cacheinfo *this_leaf;

	unsigned int index = 0;
@@ -206,19 +206,24 @@ static int cache_setup_of_node(unsigned int cpu) 
		return -ENOENT;

	}



	prev = np;



	while (index < cache_leaves(cpu)) {

		this_leaf = per_cpu_cacheinfo_idx(cpu, index);

		if (this_leaf->level != 1)

		if (this_leaf->level != 1) {

			np = of_find_next_cache_node(np);

		else

			np = of_node_get(np);/* cpu node itself */

			of_node_put(prev);

			prev = np;

			if (!np)

				break;

		}

		cache_of_set_props(this_leaf, np);

		this_leaf->fw_token = np;

		index++;

	}



	of_node_put(np);



	if (index != cache_leaves(cpu)) /* not all OF nodes populated */

		return -ENOENT;