Commit 3d9932a8 authored by Xiaoguang Wang's avatar Xiaoguang Wang Committed by Jens Axboe
Browse files

io_uring: cleanup io_alloc_async_ctx() 



Cleanup io_alloc_async_ctx() a bit, add a new __io_alloc_async_ctx(),
so io_setup_async_rw() won't need to check whether async_ctx is true
or false again.

Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Signed-off-by: default avatarXiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent bff6035d

fs/io_uring.c

+9 −3
Original line number Diff line number Diff line
@@ -2469,12 +2469,18 @@ static void io_req_map_rw(struct io_kiocb *req, ssize_t io_size, 
	}

}



static inline int __io_alloc_async_ctx(struct io_kiocb *req)

{

	req->io = kmalloc(sizeof(*req->io), GFP_KERNEL);

	return req->io == NULL;

}



static int io_alloc_async_ctx(struct io_kiocb *req)

{

	if (!io_op_defs[req->opcode].async_ctx)

		return 0;

	req->io = kmalloc(sizeof(*req->io), GFP_KERNEL);

	return req->io == NULL;



	return  __io_alloc_async_ctx(req);

}



static int io_setup_async_rw(struct io_kiocb *req, ssize_t io_size,
@@ -2484,7 +2490,7 @@ static int io_setup_async_rw(struct io_kiocb *req, ssize_t io_size, 
	if (!io_op_defs[req->opcode].async_ctx)

		return 0;

	if (!req->io) {

		if (io_alloc_async_ctx(req))

		if (__io_alloc_async_ctx(req))

			return -ENOMEM;



		io_req_map_rw(req, io_size, iovec, fast_iov, iter);