Commit 3d90d2f4 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: iwlwifi: fw: fix memory leak in debugfs 



Fix a memory leak that occurs when reading the fw_info
file all the way, since we return NULL indicating no
more data, but don't free the status tracking object.

Fixes: 36dfe9ac ("iwlwifi: dump api version in yaml format")
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230418122405.239e501b3b8d.I4268f87809ef91209cbcd748eee0863195e70fa2@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent c5050696

drivers/net/wireless/intel/iwlwifi/fw/debugfs.c

+3 −1
Original line number Diff line number Diff line
@@ -317,8 +317,10 @@ static void *iwl_dbgfs_fw_info_seq_next(struct seq_file *seq, 
	const struct iwl_fw *fw = priv->fwrt->fw;



	*pos = ++state->pos;

	if (*pos >= fw->ucode_capa.n_cmd_versions)

	if (*pos >= fw->ucode_capa.n_cmd_versions) {

		kfree(state);

		return NULL;

	}



	return state;

}