Commit 3d759e9e authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

Merge branch 'devlink-code-split-and-structured-instance-walk' 

Jakub Kicinski says:

====================
devlink: code split and structured instance walk

Split devlink.c into a handful of files, trying to keep the "core"
code away from all the command-specific implementations.
The core code has been quite scattered until now. Going forward we can
consider using a source file per-subobject, I think that it's quite
beneficial to newcomers (based on relative ease with which folks
contribute to ethtool vs devlink). But this series doesn't split
everything out, yet - partially due to backporting concerns,
but mostly due to lack of time. Bulk of the netlink command
handling is left in a leftover.c file.

Introduce a context structure for dumps, and use it to store
the devlink instance ID of the last dumped devlink instance.
This means we don't have to restart the walk from 0 each time.

Finally - introduce a "structured walk". A centralized dump handler
in devlink/netlink.c which walks the devlink instances, deals with
refcounting/locking, simplifying the per-object implementations quite
a bit. Inspired by the ethtool code.

v1: https://lore.kernel.org/all/20230104041636.226398-1-kuba@kernel.org/
RFC: https://lore.kernel.org/all/20221215020155.1619839-1-kuba@kernel.org/
====================

Link: https://lore.kernel.org/r/20230105040531.353563-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parents 0da68553 5ce76d78

MAINTAINERS

+1 −1
Original line number Diff line number Diff line
@@ -6099,7 +6099,7 @@ S: Supported 
F:	Documentation/networking/devlink

F:	include/net/devlink.h

F:	include/uapi/linux/devlink.h

F:	net/core/devlink.c

F:	net/devlink/









DH ELECTRONICS IMX6 DHCOM/DHCOR BOARD SUPPORT









M:	Christoph Niedermaier <cniedermaier@dh-electronics.com>
































include/linux/netlink.h



+4
−0






























Original line number
Diff line number
Diff line







@@ -263,6 +263,10 @@ struct netlink_callback {







	};









};



















#define NL_ASSET_DUMP_CTX_FITS(type_name)				\









	BUILD_BUG_ON(sizeof(type_name) >				\









		     sizeof_field(struct netlink_callback, ctx))



















struct netlink_notify {









	struct net *net;









	u32 portid;
































net/Makefile



+1
−0






























Original line number
Diff line number
Diff line







@@ -23,6 +23,7 @@ obj-$(CONFIG_BPFILTER)		+= bpfilter/







obj-$(CONFIG_PACKET)		+= packet/









obj-$(CONFIG_NET_KEY)		+= key/









obj-$(CONFIG_BRIDGE)		+= bridge/









obj-$(CONFIG_NET_DEVLINK)	+= devlink/









obj-$(CONFIG_NET_DSA)		+= dsa/









obj-$(CONFIG_ATALK)		+= appletalk/









obj-$(CONFIG_X25)		+= x25/
































net/core/Makefile



+0
−1






























Original line number
Diff line number
Diff line







@@ -33,7 +33,6 @@ obj-$(CONFIG_LWTUNNEL) += lwtunnel.o







obj-$(CONFIG_LWTUNNEL_BPF) += lwt_bpf.o









obj-$(CONFIG_DST_CACHE) += dst_cache.o









obj-$(CONFIG_HWBM) += hwbm.o









obj-$(CONFIG_NET_DEVLINK) += devlink.o









obj-$(CONFIG_GRO_CELLS) += gro_cells.o









obj-$(CONFIG_FAILOVER) += failover.o









obj-$(CONFIG_NET_SOCK_MSG) += skmsg.o
































net/devlink/Makefile
0 → 100644



+3
−0






























Original line number
Diff line number
Diff line









# SPDX-License-Identifier: GPL-2.0



















obj-y := leftover.o core.o netlink.o