Commit 3d710af7 authored by Vidya Sagar's avatar Vidya Sagar Committed by Lorenzo Pieralisi
Browse files

PCI: tegra: Check return value of tegra_pcie_init_controller() 

The return value of tegra_pcie_init_controller() must be checked before
PCIe link up check and registering debugfs entries subsequently as it
doesn't make sense to do these when the controller initialization itself
has failed.

Link: https://lore.kernel.org/r/20201203133451.17716-5-vidyas@nvidia.com


Tested-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarVidya Sagar <vidyas@nvidia.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: default avatarThierry Reding <treding@nvidia.com>
parent b8f0d671

drivers/pci/controller/dwc/pcie-tegra194.c

+5 −1
Original line number Diff line number Diff line
@@ -1563,7 +1563,11 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie) 
		goto fail_pm_get_sync;

	}



	tegra_pcie_init_controller(pcie);

	ret = tegra_pcie_init_controller(pcie);

	if (ret < 0) {

		dev_err(dev, "Failed to initialize controller: %d\n", ret);

		goto fail_pm_get_sync;

	}



	pcie->link_state = tegra_pcie_dw_link_up(&pcie->pci);

	if (!pcie->link_state) {