Commit 3d65492a authored Jan 17, 2022 by Roi Dayan Committed by Saeed Mahameed Feb 23, 2022

net/mlx5e: TC, Reject rules with forward and drop actions



Such rules are redundant but allowed and passed to the driver.
The driver does not support offloading such rules so return an error.

Fixes: 03a9d11e ("net/mlx5e: Add TC drop and mirred/redirect action parsing for SRIOV offloads")
Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Oz Shlomo <ozsh@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

parent 23216d38

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -3204,6 +3204,12 @@ actions_match_supported(struct mlx5e_priv *priv,
		return false;
		}

		if (!(~actions &
		(MLX5_FLOW_CONTEXT_ACTION_FWD_DEST \| MLX5_FLOW_CONTEXT_ACTION_DROP))) {
		NL_SET_ERR_MSG_MOD(extack, "Rule cannot support forward+drop action");
		return false;
		}

		if (actions & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR &&
		actions & MLX5_FLOW_CONTEXT_ACTION_DROP) {
		NL_SET_ERR_MSG_MOD(extack, "Drop with modify header action is not supported");