Commit 3d38faef authored by Yang Yingliang's avatar Yang Yingliang Committed by Kalle Valo
Browse files

ath11k: add missing of_node_put() to avoid leak 



The node pointer is returned by of_find_node_by_type()
or of_parse_phandle() with refcount incremented. Calling
of_node_put() to aovid the refcount leak.

Fixes: 6ac04bdc ("ath11k: Use reserved host DDR addresses from DT for PCI devices")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20211221114003.335557-1-yangyingliang@huawei.com
parent 8aaaf2f3

drivers/net/wireless/ath/ath11k/mhi.c

+1 −0
Original line number Diff line number Diff line
@@ -332,6 +332,7 @@ static int ath11k_mhi_read_addr_from_dt(struct mhi_controller *mhi_ctrl) 
		return -ENOENT;



	ret = of_address_to_resource(np, 0, &res);

	of_node_put(np);

	if (ret)

		return ret;

drivers/net/wireless/ath/ath11k/qmi.c

+1 −0
Original line number Diff line number Diff line
@@ -1936,6 +1936,7 @@ static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab) 
			}



			ret = of_address_to_resource(hremote_node, 0, &res);

			of_node_put(hremote_node);

			if (ret) {

				ath11k_dbg(ab, ATH11K_DBG_QMI,

					   "qmi fail to get reg from hremote\n");