Unverified Commit 3d0b93d9 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Maxime Ripard
Browse files

drm/vc4: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage 



If the device is already in a runtime PM enabled state
pm_runtime_get_sync() will return 1.

Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync()
fails, so use pm_runtime_resume_and_get() instead. this function
will handle this.

Fixes: 4078f575 ("drm/vc4: Add DSI driver")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220420135008.2757-1-linmq006@gmail.com
parent 298799a2

drivers/gpu/drm/vc4/vc4_dsi.c

+1 −1
Original line number Diff line number Diff line
@@ -846,7 +846,7 @@ static void vc4_dsi_encoder_enable(struct drm_encoder *encoder) 
	unsigned long phy_clock;

	int ret;



	ret = pm_runtime_get_sync(dev);

	ret = pm_runtime_resume_and_get(dev);

	if (ret) {

		DRM_ERROR("Failed to runtime PM enable on DSI%d\n", dsi->variant->port);

		return;