Commit 3cfef1b6 authored by Jeffle Xu's avatar Jeffle Xu Committed by David Howells
Browse files

netfs: fix parameter of cleanup() 



The order of these two parameters is just reversed. gcc didn't warn on
that, probably because 'void *' can be converted from or to other
pointer types without warning.

Cc: stable@vger.kernel.org
Fixes: 3d3c9504 ("netfs: Provide readahead and readpage netfs helpers")
Fixes: e1b1240c ("netfs: Add write_begin helper")
Signed-off-by: default avatarJeffle Xu <jefflexu@linux.alibaba.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Link: https://lore.kernel.org/r/20211207031449.100510-1-jefflexu@linux.alibaba.com/ # v1
parent 598ad0bd

fs/netfs/read_helper.c

+3 −3
Original line number Diff line number Diff line
@@ -955,7 +955,7 @@ int netfs_readpage(struct file *file, 
	rreq = netfs_alloc_read_request(ops, netfs_priv, file);

	if (!rreq) {

		if (netfs_priv)

			ops->cleanup(netfs_priv, folio_file_mapping(folio));

			ops->cleanup(folio_file_mapping(folio), netfs_priv);

		folio_unlock(folio);

		return -ENOMEM;

	}
@@ -1186,7 +1186,7 @@ int netfs_write_begin(struct file *file, struct address_space *mapping, 
		goto error;

have_folio_no_wait:

	if (netfs_priv)

		ops->cleanup(netfs_priv, mapping);

		ops->cleanup(mapping, netfs_priv);

	*_folio = folio;

	_leave(" = 0");

	return 0;
@@ -1197,7 +1197,7 @@ int netfs_write_begin(struct file *file, struct address_space *mapping, 
	folio_unlock(folio);

	folio_put(folio);

	if (netfs_priv)

		ops->cleanup(netfs_priv, mapping);

		ops->cleanup(mapping, netfs_priv);

	_leave(" = %d", ret);

	return ret;

}