Unverified Commit 3ce5a5fe authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!8523 tty: vcc: Add check for kstrdup() in vcc_probe() 

Merge Pull Request from: @ci-robot 
 
PR sync from: Yi Yang <yiyang13@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/DPF5XS5O7L2DYTWQV4SZ3U64WEIOEINQ/ 
 
https://gitee.com/src-openeuler/kernel/issues/I9RFK8 
 
Link:https://gitee.com/openeuler/kernel/pulls/8523

 

Reviewed-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
parents a0db553a d111568e

drivers/tty/vcc.c

+13 −3
Original line number Diff line number Diff line
@@ -587,18 +587,22 @@ static int vcc_probe(struct vio_dev *vdev, const struct vio_device_id *id) 
		return -ENOMEM;



	name = kstrdup(dev_name(&vdev->dev), GFP_KERNEL);

	if (!name) {

		rv = -ENOMEM;

		goto free_port;

	}



	rv = vio_driver_init(&port->vio, vdev, VDEV_CONSOLE_CON, vcc_versions,

			     ARRAY_SIZE(vcc_versions), NULL, name);

	if (rv)

		goto free_port;

		goto free_name;



	port->vio.debug = vcc_dbg_vio;

	vcc_ldc_cfg.debug = vcc_dbg_ldc;



	rv = vio_ldc_alloc(&port->vio, &vcc_ldc_cfg, port);

	if (rv)

		goto free_port;

		goto free_name;



	spin_lock_init(&port->lock);
@@ -632,6 +636,11 @@ static int vcc_probe(struct vio_dev *vdev, const struct vio_device_id *id) 
		goto unreg_tty;

	}

	port->domain = kstrdup(domain, GFP_KERNEL);

	if (!port->domain) {

		rv = -ENOMEM;

		goto unreg_tty;

	}





	mdesc_release(hp);
@@ -661,8 +670,9 @@ static int vcc_probe(struct vio_dev *vdev, const struct vio_device_id *id) 
	vcc_table_remove(port->index);

free_ldc:

	vio_ldc_free(&port->vio);

free_port:

free_name:

	kfree(name);

free_port:

	kfree(port);



	return rv;