Commit 3cd46171 authored by Yang Guo's avatar Yang Guo Committed by Theodore Ts'o
Browse files

ext4: delete redundant uptodate check for buffer 



The buffer uptodate state has been checked in function set_buffer_uptodate,
there is no need use buffer_uptodate before calling set_buffer_uptodate and
delete it.

Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: default avatarYang Guo <guoyang2@huawei.com>
Signed-off-by: default avatarShaokun Zhang <zhangshaokun@hisilicon.com>
Reviewed-by: default avatarRitesh Harjani <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/1617260610-29770-1-git-send-email-zhangshaokun@hisilicon.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 72ffb49a

fs/ext4/inode.c

+2 −4
Original line number Diff line number Diff line
@@ -1066,7 +1066,6 @@ static int ext4_block_write_begin(struct page *page, loff_t pos, unsigned len, 
		block_end = block_start + blocksize;

		if (block_end <= from || block_start >= to) {

			if (PageUptodate(page)) {

				if (!buffer_uptodate(bh))

				set_buffer_uptodate(bh);

			}

			continue;
@@ -1092,7 +1091,6 @@ static int ext4_block_write_begin(struct page *page, loff_t pos, unsigned len, 
			}

		}

		if (PageUptodate(page)) {

			if (!buffer_uptodate(bh))

			set_buffer_uptodate(bh);

			continue;

		}