Commit 3cc30e8d authored by Liu Shixin's avatar Liu Shixin Committed by Jason Gunthorpe
Browse files

RDMA/ipoib: Convert to use DEFINE_SEQ_ATTRIBUTE macro 

Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.

Link: https://lore.kernel.org/r/20200916025022.3992627-1-liushixin2@huawei.com


Signed-off-by: default avatarLiu Shixin <liushixin2@huawei.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 1d7c9958

drivers/infiniband/ulp/ipoib/ipoib_fs.c

+4 −46
Original line number Diff line number Diff line
@@ -124,35 +124,14 @@ static int ipoib_mcg_seq_show(struct seq_file *file, void *iter_ptr) 
	return 0;

}



static const struct seq_operations ipoib_mcg_seq_ops = {

static const struct seq_operations ipoib_mcg_sops = {

	.start = ipoib_mcg_seq_start,

	.next  = ipoib_mcg_seq_next,

	.stop  = ipoib_mcg_seq_stop,

	.show  = ipoib_mcg_seq_show,

};



static int ipoib_mcg_open(struct inode *inode, struct file *file)

{

	struct seq_file *seq;

	int ret;



	ret = seq_open(file, &ipoib_mcg_seq_ops);

	if (ret)

		return ret;



	seq = file->private_data;

	seq->private = inode->i_private;



	return 0;

}



static const struct file_operations ipoib_mcg_fops = {

	.owner   = THIS_MODULE,

	.open    = ipoib_mcg_open,

	.read    = seq_read,

	.llseek  = seq_lseek,

	.release = seq_release

};

DEFINE_SEQ_ATTRIBUTE(ipoib_mcg);



static void *ipoib_path_seq_start(struct seq_file *file, loff_t *pos)

{
@@ -229,35 +208,14 @@ static int ipoib_path_seq_show(struct seq_file *file, void *iter_ptr) 
	return 0;

}



static const struct seq_operations ipoib_path_seq_ops = {

static const struct seq_operations ipoib_path_sops = {

	.start = ipoib_path_seq_start,

	.next  = ipoib_path_seq_next,

	.stop  = ipoib_path_seq_stop,

	.show  = ipoib_path_seq_show,

};



static int ipoib_path_open(struct inode *inode, struct file *file)

{

	struct seq_file *seq;

	int ret;



	ret = seq_open(file, &ipoib_path_seq_ops);

	if (ret)

		return ret;



	seq = file->private_data;

	seq->private = inode->i_private;



	return 0;

}



static const struct file_operations ipoib_path_fops = {

	.owner   = THIS_MODULE,

	.open    = ipoib_path_open,

	.read    = seq_read,

	.llseek  = seq_lseek,

	.release = seq_release

};

DEFINE_SEQ_ATTRIBUTE(ipoib_path);



void ipoib_create_debug_files(struct net_device *dev)

{