Commit 3c9ad9bd authored by Joe Thornber's avatar Joe Thornber Committed by Alasdair G Kergon
Browse files

dm persistent data: stop using dm_bm_unlock_move when shadowing blocks in tm 



Stop using dm_bm_unlock_move when shadowing blocks in the transaction
manager as an optimisation and remove the function as it is then no
longer used.

Some code, such as the space maps, keeps using on-disk data structures
from the previous transaction.  It can do this because blocks won't
be reallocated until the subsequent transaction.  Using
dm_bm_unlock_move to copy blocks sounds like a win, but it forces a
synchronous read should the old block be accessed.

Signed-off-by: default avatarJoe Thornber <ejt@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarAlasdair G Kergon <agk@redhat.com>
parent 384ef0e6

drivers/md/persistent-data/dm-block-manager.c

+0 −16
Original line number Diff line number Diff line
@@ -584,22 +584,6 @@ int dm_bm_unlock(struct dm_block *b) 
}

EXPORT_SYMBOL_GPL(dm_bm_unlock);



int dm_bm_unlock_move(struct dm_block *b, dm_block_t n)

{

	struct buffer_aux *aux;



	aux = dm_bufio_get_aux_data(to_buffer(b));



	if (aux->write_locked) {

		dm_bufio_mark_buffer_dirty(to_buffer(b));

		bl_up_write(&aux->lock);

	} else

		bl_up_read(&aux->lock);



	dm_bufio_release_move(to_buffer(b), n);

	return 0;

}



int dm_bm_flush_and_unlock(struct dm_block_manager *bm,

			   struct dm_block *superblock)

{

drivers/md/persistent-data/dm-block-manager.h

+0 −8
Original line number Diff line number Diff line
@@ -96,14 +96,6 @@ int dm_bm_write_lock_zero(struct dm_block_manager *bm, dm_block_t b, 


int dm_bm_unlock(struct dm_block *b);



/*

 * An optimisation; we often want to copy a block's contents to a new

 * block.  eg, as part of the shadowing operation.  It's far better for

 * bufio to do this move behind the scenes than hold 2 locks and memcpy the

 * data.

 */

int dm_bm_unlock_move(struct dm_block *b, dm_block_t n);



/*

 * It's a common idiom to have a superblock that should be committed last.

 *

drivers/md/persistent-data/dm-transaction-manager.c

+14 −3
Original line number Diff line number Diff line
@@ -219,13 +219,24 @@ static int __shadow_block(struct dm_transaction_manager *tm, dm_block_t orig, 
	if (r < 0)

		return r;



	r = dm_bm_unlock_move(orig_block, new);

	if (r < 0) {

	/*

	 * It would be tempting to use dm_bm_unlock_move here, but some

	 * code, such as the space maps, keeps using the old data structures

	 * secure in the knowledge they won't be changed until the next

	 * transaction.  Using unlock_move would force a synchronous read

	 * since the old block would no longer be in the cache.

	 */

	r = dm_bm_write_lock_zero(tm->bm, new, v, result);

	if (r) {

		dm_bm_unlock(orig_block);

		return r;

	}



	return dm_bm_write_lock(tm->bm, new, v, result);

	memcpy(dm_block_data(*result), dm_block_data(orig_block),

	       dm_bm_block_size(tm->bm));



	dm_bm_unlock(orig_block);

	return r;

}



int dm_tm_shadow_block(struct dm_transaction_manager *tm, dm_block_t orig,