Commit 3c8e99cc authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/amdgpu/display: simplify backlight setting 



Avoid the extra wrapper function.

Reviewed-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1b1cbf92

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+4 −16
Original line number Original line Diff line number Diff line
@@ -3270,19 +3270,6 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm) 
#endif

#endif

}

}





static int set_backlight_via_aux(struct dc_link *link, uint32_t brightness)

{

	bool rc;



	if (!link)

		return 1;



	rc = dc_link_set_backlight_level_nits(link, true, brightness,

					      AUX_BL_DEFAULT_TRANSITION_TIME_MS);



	return rc ? 0 : 1;

}



static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,

static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,

				unsigned *min, unsigned *max)

				unsigned *min, unsigned *max)

{

{
@@ -3345,8 +3332,9 @@ static int amdgpu_dm_backlight_update_status(struct backlight_device *bd) 
	brightness = convert_brightness_from_user(&caps, bd->props.brightness);

	brightness = convert_brightness_from_user(&caps, bd->props.brightness);

	// Change brightness based on AUX property

	// Change brightness based on AUX property

	if (caps.aux_support)

	if (caps.aux_support)

		return set_backlight_via_aux(link, brightness);

		rc = dc_link_set_backlight_level_nits(link, true, brightness,



						      AUX_BL_DEFAULT_TRANSITION_TIME_MS);

	else

		rc = dc_link_set_backlight_level(dm->backlight_link, brightness, 0);

		rc = dc_link_set_backlight_level(dm->backlight_link, brightness, 0);





	return rc ? 0 : 1;

	return rc ? 0 : 1;