Commit 3c3ee165 authored by Chaitanya Kulkarni's avatar Chaitanya Kulkarni Committed by Christoph Hellwig
Browse files

nvmet: use NVMET_MAX_NAMESPACES to set nn value 



For Spec regarding MNAN value:-

If the controller supports Asymmetric Namespace Access Reporting, then
this field shall be set to a non-zero value that is less than or equal
to the NN value.

Instead of using subsys->max_nsid that gets calculated dynamically,
use NVMET_MAX_NAMESPACES value to report NN. This way we will maintain
the MNAN value spec compliant with NN.

Without this patch, code results in the following error :-

[337976.409142] nvme nvme1: Invalid MNAN value 1024

Signed-off-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 8cf486e1

drivers/nvme/target/admin-cmd.c

+1 −1
Original line number Diff line number Diff line
@@ -422,7 +422,7 @@ static void nvmet_execute_identify_ctrl(struct nvmet_req *req) 
	/* no enforcement soft-limit for maxcmd - pick arbitrary high value */

	id->maxcmd = cpu_to_le16(NVMET_MAX_CMD);



	id->nn = cpu_to_le32(ctrl->subsys->max_nsid);

	id->nn = cpu_to_le32(NVMET_MAX_NAMESPACES);

	id->mnan = cpu_to_le32(NVMET_MAX_NAMESPACES);

	id->oncs = cpu_to_le16(NVME_CTRL_ONCS_DSM |

			NVME_CTRL_ONCS_WRITE_ZEROES);