Commit 3c0dfe6e authored by Andrii Nakryiko's avatar Andrii Nakryiko Committed by Alexei Starovoitov
Browse files

libbpf: Use strlcpy() in path resolution fallback logic 



Coverity static analyzer complains that strcpy() can cause buffer
overflow. Use libbpf_strlcpy() instead to be 100% sure this doesn't
happen.

Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20220407230446.3980075-1-andrii@kernel.org
parent 700a6ef1

tools/lib/bpf/usdt.c

+1 −1
Original line number Diff line number Diff line
@@ -456,7 +456,7 @@ static int parse_lib_segs(int pid, const char *lib_path, struct elf_seg **segs, 
	if (!realpath(lib_path, path)) {

		pr_warn("usdt: failed to get absolute path of '%s' (err %d), using path as is...\n",

			lib_path, -errno);

		strcpy(path, lib_path);

		libbpf_strlcpy(path, lib_path, sizeof(path));

	}



proceed: