Unverified Commit 3be46fa2 authored by Guennadi Liakhovetski's avatar Guennadi Liakhovetski Committed by Mark Brown
Browse files

ASoC: SOF: remove unused functions 



hda_dsp_dump_skl() is never used and hda_dsp_get_status_skl() is
only called from that function. Remove both functions.

Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarKeyon Jie <yang.jie@intel.com>
Signed-off-by: default avatarGuennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210208232149.58899-4-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ce1f55ba

sound/soc/sof/intel/hda.c

+0 −50
Original line number Diff line number Diff line
@@ -317,26 +317,6 @@ static const struct hda_dsp_msg_code hda_dsp_rom_msg[] = { 
	{HDA_DSP_ROM_NULL_FW_ENTRY,	"error: null FW entry point"},

};



static void hda_dsp_get_status_skl(struct snd_sof_dev *sdev)

{

	u32 status;

	int i;



	status = snd_sof_dsp_read(sdev, HDA_DSP_BAR,

				  HDA_ADSP_FW_STATUS_SKL);



	for (i = 0; i < ARRAY_SIZE(hda_dsp_rom_msg); i++) {

		if (status == hda_dsp_rom_msg[i].code) {

			dev_err(sdev->dev, "%s - code %8.8x\n",

				hda_dsp_rom_msg[i].msg, status);

			return;

		}

	}



	/* not for us, must be generic sof message */

	dev_dbg(sdev->dev, "unknown ROM status value %8.8x\n", status);

}



static void hda_dsp_get_status(struct snd_sof_dev *sdev)

{

	u32 status;
@@ -385,36 +365,6 @@ static void hda_dsp_get_registers(struct snd_sof_dev *sdev, 
		       stack_words * sizeof(u32));

}



void hda_dsp_dump_skl(struct snd_sof_dev *sdev, u32 flags)

{

	struct sof_ipc_dsp_oops_xtensa xoops;

	struct sof_ipc_panic_info panic_info;

	u32 stack[HDA_DSP_STACK_DUMP_SIZE];

	u32 status, panic;



	/* try APL specific status message types first */

	hda_dsp_get_status_skl(sdev);



	/* now try generic SOF status messages */

	status = snd_sof_dsp_read(sdev, HDA_DSP_BAR,

				  HDA_ADSP_ERROR_CODE_SKL);



	/*TODO: Check: there is no define in spec, but it is used in the code*/

	panic = snd_sof_dsp_read(sdev, HDA_DSP_BAR,

				 HDA_ADSP_ERROR_CODE_SKL + 0x4);



	if (sdev->fw_state == SOF_FW_BOOT_COMPLETE) {

		hda_dsp_get_registers(sdev, &xoops, &panic_info, stack,

				      HDA_DSP_STACK_DUMP_SIZE);

		snd_sof_get_status(sdev, status, panic, &xoops, &panic_info,

				   stack, HDA_DSP_STACK_DUMP_SIZE);

	} else {

		dev_err(sdev->dev, "error: status = 0x%8.8x panic = 0x%8.8x\n",

			status, panic);

		hda_dsp_get_status_skl(sdev);

	}

}



/* dump the first 8 dwords representing the extended ROM status */

static void hda_dsp_dump_ext_rom_status(struct snd_sof_dev *sdev, u32 flags)

{

sound/soc/sof/intel/hda.h

+0 −1
Original line number Diff line number Diff line
@@ -517,7 +517,6 @@ int hda_dsp_runtime_suspend(struct snd_sof_dev *sdev); 
int hda_dsp_runtime_resume(struct snd_sof_dev *sdev);

int hda_dsp_runtime_idle(struct snd_sof_dev *sdev);

int hda_dsp_set_hw_params_upon_resume(struct snd_sof_dev *sdev);

void hda_dsp_dump_skl(struct snd_sof_dev *sdev, u32 flags);

void hda_dsp_dump(struct snd_sof_dev *sdev, u32 flags);

void hda_ipc_dump(struct snd_sof_dev *sdev);

void hda_ipc_irq_dump(struct snd_sof_dev *sdev);