Commit 3be45625 authored by Dexuan Cui's avatar Dexuan Cui Committed by Christoph Hellwig
Browse files

dma-direct: use the correct size for dma_set_encrypted() 



The third parameter of dma_set_encrypted() is a size in bytes rather than
the number of pages.

Fixes: 4d056478 ("dma-direct: factor out dma_set_{de,en}crypted helpers")
Signed-off-by: default avatarDexuan Cui <decui@microsoft.com>
Reviewed-by: default avatarRobin Murphy <robin.murphy@arm.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent a111daf0

kernel/dma/direct.c

+2 −3
Original line number Diff line number Diff line
@@ -357,7 +357,7 @@ void dma_direct_free(struct device *dev, size_t size, 
	} else {

		if (IS_ENABLED(CONFIG_ARCH_HAS_DMA_CLEAR_UNCACHED))

			arch_dma_clear_uncached(cpu_addr, size);

		if (dma_set_encrypted(dev, cpu_addr, 1 << page_order))

		if (dma_set_encrypted(dev, cpu_addr, size))

			return;

	}
@@ -392,7 +392,6 @@ void dma_direct_free_pages(struct device *dev, size_t size, 
		struct page *page, dma_addr_t dma_addr,

		enum dma_data_direction dir)

{

	unsigned int page_order = get_order(size);

	void *vaddr = page_address(page);



	/* If cpu_addr is not from an atomic pool, dma_free_from_pool() fails */
@@ -400,7 +399,7 @@ void dma_direct_free_pages(struct device *dev, size_t size, 
	    dma_free_from_pool(dev, vaddr, size))

		return;



	if (dma_set_encrypted(dev, vaddr, 1 << page_order))

	if (dma_set_encrypted(dev, vaddr, size))

		return;

	__dma_direct_free_pages(dev, page, size);

}