Commit 3bd3bc2a authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Vinod Koul
Browse files

soundwire: bus: Remove unused reset_page_addr() callback 



A previous patch removed unnecessary zeroing of the page registers
after a paged transaction, so now the reset_page_addr callback is
unused and can be removed.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230123164949.245898-3-rf@opensource.cirrus.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent c8a0d6b2

drivers/soundwire/cadence_master.c

+0 −14
Original line number Diff line number Diff line
@@ -770,20 +770,6 @@ cdns_xfer_msg_defer(struct sdw_bus *bus, 
}

EXPORT_SYMBOL(cdns_xfer_msg_defer);



enum sdw_command_response

cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num)

{

	struct sdw_cdns *cdns = bus_to_cdns(bus);

	struct sdw_msg msg;



	/* Create dummy message with valid device number */

	memset(&msg, 0, sizeof(msg));

	msg.dev_num = dev_num;



	return cdns_program_scp_addr(cdns, &msg);

}

EXPORT_SYMBOL(cdns_reset_page_addr);



u32 cdns_read_ping_status(struct sdw_bus *bus)

{

	struct sdw_cdns *cdns = bus_to_cdns(bus);

drivers/soundwire/cadence_master.h

+0 −3
Original line number Diff line number Diff line
@@ -182,9 +182,6 @@ struct sdw_cdns_pdi *sdw_cdns_alloc_pdi(struct sdw_cdns *cdns, 
void sdw_cdns_config_stream(struct sdw_cdns *cdns,

			    u32 ch, u32 dir, struct sdw_cdns_pdi *pdi);



enum sdw_command_response

cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num);



enum sdw_command_response

cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg);

drivers/soundwire/intel_auxdevice.c

+0 −1
Original line number Diff line number Diff line
@@ -113,7 +113,6 @@ static struct sdw_master_ops sdw_intel_ops = { 
	.override_adr = sdw_dmi_override_adr,

	.xfer_msg = cdns_xfer_msg,

	.xfer_msg_defer = cdns_xfer_msg_defer,

	.reset_page_addr = cdns_reset_page_addr,

	.set_bus_conf = cdns_bus_conf,

	.pre_bank_switch = generic_pre_bank_switch,

	.post_bank_switch = generic_post_bank_switch,

include/linux/soundwire/sdw.h

+0 −3
Original line number Diff line number Diff line
@@ -838,7 +838,6 @@ struct sdw_defer { 
 * @override_adr: Override value read from firmware (quirk for buggy firmware)

 * @xfer_msg: Transfer message callback

 * @xfer_msg_defer: Defer version of transfer message callback

 * @reset_page_addr: Reset the SCP page address registers

 * @set_bus_conf: Set the bus configuration

 * @pre_bank_switch: Callback for pre bank switch

 * @post_bank_switch: Callback for post bank switch
@@ -854,8 +853,6 @@ struct sdw_master_ops { 
	enum sdw_command_response (*xfer_msg_defer)

			(struct sdw_bus *bus, struct sdw_msg *msg,

			struct sdw_defer *defer);

	enum sdw_command_response (*reset_page_addr)

			(struct sdw_bus *bus, unsigned int dev_num);

	int (*set_bus_conf)(struct sdw_bus *bus,

			struct sdw_bus_params *params);

	int (*pre_bank_switch)(struct sdw_bus *bus);