Commit 3bce981f authored by Matthew Auld's avatar Matthew Auld
Browse files

drm/i915: remove the TODO in pin_and_fence_fb_obj 



The copy is async (if there even is one), but when later updating the
GGTT we always sync against the binding, which will in turn sync against
any moves.

Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
Cc: Jianshui Yu <jianshui.yu@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221004131916.233474-1-matthew.auld@intel.com
parent 0add082c

drivers/gpu/drm/i915/display/intel_fb_pin.c

+0 −1
Original line number Diff line number Diff line
@@ -141,7 +141,6 @@ intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb, 
		ret = i915_gem_object_attach_phys(obj, alignment);

	else if (!ret && HAS_LMEM(dev_priv))

		ret = i915_gem_object_migrate(obj, &ww, INTEL_REGION_LMEM_0);

	/* TODO: Do we need to sync when migration becomes async? */

	if (!ret)

		ret = i915_gem_object_pin_pages(obj);

	if (ret)