Commit 3bb5746c authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Jens Axboe
Browse files

pktcdvd: use sysfs_emit() to instead of scnprintf() 



Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20230310164549.22133-4-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 1a0ddd56

drivers/block/pktcdvd.c

+1 −1
Original line number Diff line number Diff line
@@ -335,7 +335,7 @@ static ssize_t device_map_show(const struct class *c, const struct class_attribu 
		struct pktcdvd_device *pd = pkt_devs[idx];

		if (!pd)

			continue;

		n += sprintf(data+n, "%s %u:%u %u:%u\n",

		n += sysfs_emit_at(data, n, "%s %u:%u %u:%u\n",

			pd->disk->disk_name,

			MAJOR(pd->pkt_dev), MINOR(pd->pkt_dev),

			MAJOR(pd->bdev->bd_dev),