Commit 3ba0bf47 authored by Jesse Brandeburg's avatar Jesse Brandeburg Committed by Paolo Abeni
Browse files

net/core: refactor promiscuous mode message 



The kernel stack can be more consistent by printing the IFF_PROMISC
aka promiscuous enable/disable messages with the standard netdev_info
message which can include bus and driver info as well as the device.

typical command usage from user space looks like:
ip link set eth0 promisc <on|off>

But lots of utilities such as bridge, tcpdump, etc put the interface into
promiscuous mode.

old message:
[  406.034418] device eth0 entered promiscuous mode
[  408.424703] device eth0 left promiscuous mode

new message:
[  406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode
[  408.424715] ice 0000:17:00.0 eth0: left promiscuous mode

Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 802dcbd6

net/core/dev.c

+2 −3
Original line number Diff line number Diff line
@@ -8321,8 +8321,7 @@ static int __dev_set_promiscuity(struct net_device *dev, int inc, bool notify) 
		}

	}

	if (dev->flags != old_flags) {

		pr_info("device %s %s promiscuous mode\n",

			dev->name,

		netdev_info(dev, "%s promiscuous mode\n",

			    dev->flags & IFF_PROMISC ? "entered" : "left");

		if (audit_enabled) {

			current_uid_gid(&uid, &gid);