Commit 3b770932 authored by Yang Yingliang's avatar Yang Yingliang Committed by Jiri Kosina
Browse files

HID: thrustmaster: Switch to kmemdup() when allocate change_request 



Use kmemdup() helper instead of open-coding to
simplify the code when allocate change_request.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 424d8237

drivers/hid/hid-thrustmaster.c

+3 −2
Original line number Diff line number Diff line
@@ -311,12 +311,13 @@ static int thrustmaster_probe(struct hid_device *hdev, const struct hid_device_i 
		goto error4;

	}



	tm_wheel->change_request = kzalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL);

	tm_wheel->change_request = kmemdup(&change_request,

					   sizeof(struct usb_ctrlrequest),

					   GFP_KERNEL);

	if (!tm_wheel->change_request) {

		ret = -ENOMEM;

		goto error5;

	}

	memcpy(tm_wheel->change_request, &change_request, sizeof(struct usb_ctrlrequest));



	tm_wheel->usb_dev = interface_to_usbdev(to_usb_interface(hdev->dev.parent));

	hid_set_drvdata(hdev, tm_wheel);