Commit 3b64e41b authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau
Browse files

mt76: always init to 0 mcu messages 



Always initialize to 0 mcu messages since if they are not propely
configured they could hang the firmware.

Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 2ee920c2

drivers/net/wireless/mediatek/mt76/mcu.c

+4 −2
Original line number Diff line number Diff line
@@ -9,14 +9,16 @@ struct sk_buff * 
mt76_mcu_msg_alloc(const void *data, int head_len,

		   int data_len, int tail_len)

{

	int length = head_len + data_len + tail_len;

	struct sk_buff *skb;



	skb = alloc_skb(head_len + data_len + tail_len,

			GFP_KERNEL);

	skb = alloc_skb(length, GFP_KERNEL);

	if (!skb)

		return NULL;



	memset(skb->head, 0, length);

	skb_reserve(skb, head_len);



	if (data && data_len)

		skb_put_data(skb, data, data_len);

drivers/net/wireless/mediatek/mt76/mt7603/mcu.c

+0 −1
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ __mt7603_mcu_msg_send(struct mt7603_dev *dev, struct sk_buff *skb, 
		seq = ++mdev->mcu.msg_seq & 0xf;



	txd = (struct mt7603_mcu_txd *)skb_push(skb, hdrlen);

	memset(txd, 0, hdrlen);



	txd->len = cpu_to_le16(skb->len);

	if (cmd == -MCU_CMD_FW_SCATTER)

drivers/net/wireless/mediatek/mt76/mt7615/mcu.c

+0 −1
Original line number Diff line number Diff line
@@ -62,7 +62,6 @@ void mt7615_mcu_fill_msg(struct mt7615_dev *dev, struct sk_buff *skb, 
		seq = ++dev->mt76.mcu.msg_seq & 0xf;



	mcu_txd = (struct mt7615_mcu_txd *)skb_push(skb, sizeof(*mcu_txd));

	memset(mcu_txd, 0, sizeof(*mcu_txd));



	if (cmd != -MCU_CMD_FW_SCATTER) {

		q_idx = MT_TX_MCU_PORT_RX_Q0;