Commit 3b49a7ed authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5e: TC, Reject rules with multiple CT actions 



The driver doesn't support multiple CT actions.
Multiple CT clear actions are ok as they are redundant also with
another CT actions.

Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarOz Shlomo <ozsh@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent ff993167

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/act.h

+1 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ struct mlx5e_tc_act_parse_state { 
	unsigned int num_actions;

	struct mlx5e_tc_flow *flow;

	struct netlink_ext_ack *extack;

	bool ct;

	bool encap;

	bool decap;

	bool mpls_push;

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/ct.c

+10 −0
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ tc_act_can_offload_ct(struct mlx5e_tc_act_parse_state *parse_state, 
		      int act_index,

		      struct mlx5_flow_attr *attr)

{

	bool clear_action = act->ct.action & TCA_CT_ACT_CLEAR;

	struct netlink_ext_ack *extack = parse_state->extack;



	if (flow_flag_test(parse_state->flow, SAMPLE)) {
@@ -19,6 +20,11 @@ tc_act_can_offload_ct(struct mlx5e_tc_act_parse_state *parse_state, 
		return false;

	}



	if (parse_state->ct && !clear_action) {

		NL_SET_ERR_MSG_MOD(extack, "Multiple CT actions are not supoported");

		return false;

	}



	return true;

}
@@ -28,6 +34,7 @@ tc_act_parse_ct(struct mlx5e_tc_act_parse_state *parse_state, 
		struct mlx5e_priv *priv,

		struct mlx5_flow_attr *attr)

{

	bool clear_action = act->ct.action & TCA_CT_ACT_CLEAR;

	int err;



	err = mlx5_tc_ct_parse_action(parse_state->ct_priv, attr,
@@ -41,6 +48,9 @@ tc_act_parse_ct(struct mlx5e_tc_act_parse_state *parse_state, 
	if (mlx5e_is_eswitch_flow(parse_state->flow))

		attr->esw_attr->split_count = attr->esw_attr->out_count;



	if (!clear_action)

		parse_state->ct = true;



	return 0;

}