Commit 3b2a35b5 authored by Wei Li's avatar Wei Li
Browse files

arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process 

mainline inclusion
from mainline-v6.10-rc3
commit 14951beaec93696b092a906baa0f29322cf34004
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IA67DS

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=14951beaec93696b092a906baa0f29322cf34004



--------------------------------

The function run_all_insn_set_hw_mode() is registered as startup callback
of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of
all emulated instructions.

As the STARTING callbacks are not expected to fail, if one of the
set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for
'setend', it will report a warning:

```
CPU[2] cannot support the emulation of setend
CPU 2 UP state arm64/isndep:starting (136) failed (-22)
CPU2: Booted secondary processor 0x0000000002 [0x414fd0c1]
```

To fix it, add a check for INSN_UNAVAILABLE status and skip the process.

Signed-off-by: default avatarWei Li <liwei391@huawei.com>
Tested-by: default avatarHuisong Li <lihuisong@huawei.com>
Link: https://lore.kernel.org/r/20240423093501.3460764-1-liwei391@huawei.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent cd2b95c3

arch/arm64/kernel/armv8_deprecated.c

+3 −0
Original line number Diff line number Diff line
@@ -464,6 +464,9 @@ static int run_all_insn_set_hw_mode(unsigned int cpu) 
	for (int i = 0; i < ARRAY_SIZE(insn_emulations); i++) {

		struct insn_emulation *insn = insn_emulations[i];

		bool enable = READ_ONCE(insn->current_mode) == INSN_HW;

		if (insn->status == INSN_UNAVAILABLE)

			continue;



		if (insn->set_hw_mode && insn->set_hw_mode(enable)) {

			pr_warn("CPU[%u] cannot support the emulation of %s",

				cpu, insn->name);