Commit 3b1f864c authored by Luoyouming's avatar Luoyouming Committed by Jason Gunthorpe
Browse files

RDMA/hns: Repacing 'dseg_len' by macros in fill_ext_sge_inl_data() 

The sge size is known to be constant, so it's unnecessary to use sizeof to
calculate.

Link: https://lore.kernel.org/r/20220922123315.3732205-11-xuhaoyue1@hisilicon.com


Signed-off-by: default avatarLuoyouming <luoyouming@huawei.com>
Signed-off-by: default avatarHaoyue Xu <xuhaoyue1@hisilicon.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 6649b4a1

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+3 −4
Original line number Diff line number Diff line
@@ -193,8 +193,7 @@ static int fill_ext_sge_inl_data(struct hns_roce_qp *qp, 
				 unsigned int *sge_idx, u32 msg_len)

{

	struct ib_device *ibdev = &(to_hr_dev(qp->ibqp.device))->ib_dev;

	unsigned int dseg_len = sizeof(struct hns_roce_v2_wqe_data_seg);

	unsigned int ext_sge_sz = qp->sq.max_gs * dseg_len;

	unsigned int ext_sge_sz = qp->sq.max_gs * HNS_ROCE_SGE_SIZE;

	unsigned int left_len_in_pg;

	unsigned int idx = *sge_idx;

	unsigned int i = 0;
@@ -222,7 +221,7 @@ static int fill_ext_sge_inl_data(struct hns_roce_qp *qp, 
		if (len <= left_len_in_pg) {

			memcpy(dseg, addr, len);



			idx += len / dseg_len;

			idx += len / HNS_ROCE_SGE_SIZE;



			i++;

			if (i >= wr->num_sge)
@@ -237,7 +236,7 @@ static int fill_ext_sge_inl_data(struct hns_roce_qp *qp, 


			len -= left_len_in_pg;

			addr += left_len_in_pg;

			idx += left_len_in_pg / dseg_len;

			idx += left_len_in_pg / HNS_ROCE_SGE_SIZE;

			dseg = hns_roce_get_extend_sge(qp,

						idx & (qp->sge.sge_cnt - 1));

			left_len_in_pg = 1 << HNS_HW_PAGE_SHIFT;