Commit 3b022865 authored by David Ahern's avatar David Ahern Committed by David S. Miller
Browse files

net: devinet: Refactor inet_netconf_notify_devconf to take event 



Refactor inet_netconf_notify_devconf to take the event as an input arg.

Signed-off-by: default avatarDavid Ahern <dsa@cumulusnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 983701eb

include/linux/inetdevice.h

+2 −2
Original line number Diff line number Diff line
@@ -153,8 +153,8 @@ struct in_ifaddr { 
int register_inetaddr_notifier(struct notifier_block *nb);

int unregister_inetaddr_notifier(struct notifier_block *nb);



void inet_netconf_notify_devconf(struct net *net, int type, int ifindex,

				 struct ipv4_devconf *devconf);

void inet_netconf_notify_devconf(struct net *net, int event, int type,

				 int ifindex, struct ipv4_devconf *devconf);



struct net_device *__ip_dev_find(struct net *net, __be32 addr, bool devref);

static inline struct net_device *ip_dev_find(struct net *net, __be32 addr)

net/ipv4/devinet.c

+20 −12
Original line number Diff line number Diff line
@@ -1831,8 +1831,8 @@ static int inet_netconf_fill_devconf(struct sk_buff *skb, int ifindex, 
	return -EMSGSIZE;

}



void inet_netconf_notify_devconf(struct net *net, int type, int ifindex,

				 struct ipv4_devconf *devconf)

void inet_netconf_notify_devconf(struct net *net, int event, int type,

				 int ifindex, struct ipv4_devconf *devconf)

{

	struct sk_buff *skb;

	int err = -ENOBUFS;
@@ -1842,7 +1842,7 @@ void inet_netconf_notify_devconf(struct net *net, int type, int ifindex, 
		goto errout;



	err = inet_netconf_fill_devconf(skb, ifindex, devconf, 0, 0,

					RTM_NEWNETCONF, 0, type);

					event, 0, type);

	if (err < 0) {

		/* -EMSGSIZE implies BUG in inet_netconf_msgsize_devconf() */

		WARN_ON(err == -EMSGSIZE);
@@ -2021,10 +2021,12 @@ static void inet_forward_change(struct net *net) 


	IPV4_DEVCONF_ALL(net, ACCEPT_REDIRECTS) = !on;

	IPV4_DEVCONF_DFLT(net, FORWARDING) = on;

	inet_netconf_notify_devconf(net, NETCONFA_FORWARDING,

	inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

				    NETCONFA_FORWARDING,

				    NETCONFA_IFINDEX_ALL,

				    net->ipv4.devconf_all);

	inet_netconf_notify_devconf(net, NETCONFA_FORWARDING,

	inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

				    NETCONFA_FORWARDING,

				    NETCONFA_IFINDEX_DEFAULT,

				    net->ipv4.devconf_dflt);
@@ -2037,7 +2039,8 @@ static void inet_forward_change(struct net *net) 
		in_dev = __in_dev_get_rtnl(dev);

		if (in_dev) {

			IN_DEV_CONF_SET(in_dev, FORWARDING, on);

			inet_netconf_notify_devconf(net, NETCONFA_FORWARDING,

			inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

						    NETCONFA_FORWARDING,

						    dev->ifindex, &in_dev->cnf);

		}

	}
@@ -2082,19 +2085,22 @@ static int devinet_conf_proc(struct ctl_table *ctl, int write, 
		if (i == IPV4_DEVCONF_RP_FILTER - 1 &&

		    new_value != old_value) {

			ifindex = devinet_conf_ifindex(net, cnf);

			inet_netconf_notify_devconf(net, NETCONFA_RP_FILTER,

			inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

						    NETCONFA_RP_FILTER,

						    ifindex, cnf);

		}

		if (i == IPV4_DEVCONF_PROXY_ARP - 1 &&

		    new_value != old_value) {

			ifindex = devinet_conf_ifindex(net, cnf);

			inet_netconf_notify_devconf(net, NETCONFA_PROXY_NEIGH,

			inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

						    NETCONFA_PROXY_NEIGH,

						    ifindex, cnf);

		}

		if (i == IPV4_DEVCONF_IGNORE_ROUTES_WITH_LINKDOWN - 1 &&

		    new_value != old_value) {

			ifindex = devinet_conf_ifindex(net, cnf);

			inet_netconf_notify_devconf(net, NETCONFA_IGNORE_ROUTES_WITH_LINKDOWN,

			inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

						    NETCONFA_IGNORE_ROUTES_WITH_LINKDOWN,

						    ifindex, cnf);

		}

	}
@@ -2129,7 +2135,7 @@ static int devinet_sysctl_forward(struct ctl_table *ctl, int write, 
					container_of(cnf, struct in_device, cnf);

				if (*valp)

					dev_disable_lro(idev->dev);

				inet_netconf_notify_devconf(net,

				inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

							    NETCONFA_FORWARDING,

							    idev->dev->ifindex,

							    cnf);
@@ -2137,7 +2143,8 @@ static int devinet_sysctl_forward(struct ctl_table *ctl, int write, 
			rtnl_unlock();

			rt_cache_flush(net);

		} else

			inet_netconf_notify_devconf(net, NETCONFA_FORWARDING,

			inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

						    NETCONFA_FORWARDING,

						    NETCONFA_IFINDEX_DEFAULT,

						    net->ipv4.devconf_dflt);

	}
@@ -2259,7 +2266,8 @@ static int __devinet_sysctl_register(struct net *net, char *dev_name, 


	p->sysctl = t;



	inet_netconf_notify_devconf(net, NETCONFA_ALL, ifindex, p);

	inet_netconf_notify_devconf(net, RTM_NEWNETCONF, NETCONFA_ALL,

				    ifindex, p);

	return 0;



free:

net/ipv4/ipmr.c

+7 −5
Original line number Diff line number Diff line
@@ -631,7 +631,7 @@ static int vif_delete(struct mr_table *mrt, int vifi, int notify, 
	in_dev = __in_dev_get_rtnl(dev);

	if (in_dev) {

		IPV4_DEVCONF(in_dev->cnf, MC_FORWARDING)--;

		inet_netconf_notify_devconf(dev_net(dev),

		inet_netconf_notify_devconf(dev_net(dev), RTM_NEWNETCONF,

					    NETCONFA_MC_FORWARDING,

					    dev->ifindex, &in_dev->cnf);

		ip_rt_multicast_event(in_dev);
@@ -820,8 +820,8 @@ static int vif_add(struct net *net, struct mr_table *mrt, 
		return -EADDRNOTAVAIL;

	}

	IPV4_DEVCONF(in_dev->cnf, MC_FORWARDING)++;

	inet_netconf_notify_devconf(net, NETCONFA_MC_FORWARDING, dev->ifindex,

				    &in_dev->cnf);

	inet_netconf_notify_devconf(net, RTM_NEWNETCONF, NETCONFA_MC_FORWARDING,

				    dev->ifindex, &in_dev->cnf);

	ip_rt_multicast_event(in_dev);



	/* Fill in the VIF structures */
@@ -1282,7 +1282,8 @@ static void mrtsock_destruct(struct sock *sk) 
	ipmr_for_each_table(mrt, net) {

		if (sk == rtnl_dereference(mrt->mroute_sk)) {

			IPV4_DEVCONF_ALL(net, MC_FORWARDING)--;

			inet_netconf_notify_devconf(net, NETCONFA_MC_FORWARDING,

			inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

						    NETCONFA_MC_FORWARDING,

						    NETCONFA_IFINDEX_ALL,

						    net->ipv4.devconf_all);

			RCU_INIT_POINTER(mrt->mroute_sk, NULL);
@@ -1344,7 +1345,8 @@ int ip_mroute_setsockopt(struct sock *sk, int optname, char __user *optval, 
		if (ret == 0) {

			rcu_assign_pointer(mrt->mroute_sk, sk);

			IPV4_DEVCONF_ALL(net, MC_FORWARDING)++;

			inet_netconf_notify_devconf(net, NETCONFA_MC_FORWARDING,

			inet_netconf_notify_devconf(net, RTM_NEWNETCONF,

						    NETCONFA_MC_FORWARDING,

						    NETCONFA_IFINDEX_ALL,

						    net->ipv4.devconf_all);

		}