Commit 3aed1129 authored by Dan Carpenter's avatar Dan Carpenter Committed by Bjorn Andersson
Browse files

soc: qcom: Fix a IS_ERR() vs NULL bug in probe 



The devm_ioremap() function returns NULL on error, it never returns
error pointers.

Fixes: a77b2a0b ("soc: qcom: Introduce RPM master stats driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/ZH7sgpLAN23bCz9v@moroto
parent d9c2a255

drivers/soc/qcom/rpm_master_stats.c

+1 −1
Original line number Diff line number Diff line
@@ -105,7 +105,7 @@ static int master_stats_probe(struct platform_device *pdev) 
		}



		data[i].base = devm_ioremap(dev, res.start, resource_size(&res));

		if (IS_ERR(data[i].base)) {

		if (!data[i].base) {

			debugfs_remove_recursive(root);

			return dev_err_probe(dev, -EINVAL,

					     "Could not map the MSG RAM slice idx %d!\n", i);